Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad example code for SP default parameters [DOC29] #38

Closed
firebird-automations opened this issue May 9, 2008 · 4 comments
Closed

Bad example code for SP default parameters [DOC29] #38

firebird-automations opened this issue May 9, 2008 · 4 comments

Comments

@firebird-automations
Copy link

Submitted by: Ain Valtin (ain)

In FB 2.1 release notes, in chapter "Defaults for Stored Procedure Arguments" the example creates selectable stored procedure (named P1) and then executes it (ie EXECUTE PROCEDURE P1). Executing selectable SP isn't allowed (?) and thus the example is incorrect (or at least bad style).

@firebird-automations
Copy link
Author

Modified by: @paulvink

assignee: Paul Vinkenoog [ paulvink ] => Helen Borrie [ helebor ]

@firebird-automations
Copy link
Author

Commented by: @helebor

The OP is correct: this is not an example of sound PSQL programming practice. However, it should be obvious that the author used it in the examples to illustrate the working of the new feature. A comment was added to the article in the release notes.

@firebird-automations
Copy link
Author

Commented by: @helebor

But added a note that using SUSPEND in an executable SP is not recommended practice.

@firebird-automations
Copy link
Author

Modified by: @helebor

status: Open [ 1 ] => Closed [ 6 ]

resolution: Won't Fix [ 2 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants