Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FBConnection.getClientInfo() [JDBC126] #168

Closed
firebird-automations opened this issue Aug 11, 2008 · 6 comments
Closed

Implement FBConnection.getClientInfo() [JDBC126] #168

firebird-automations opened this issue Aug 11, 2008 · 6 comments

Comments

@firebird-automations
Copy link

Submitted by: Felipe Jaekel (fkj)

Assigned to: Roman Rokytskyy (rrokytskyy)

Attachments:
stacktrace.txt

Implement org.firebirdsql.jdbc.FBConnection.getClientInfo(FBConnection.java:268), or make the method return null instead of throwing the java.sql.SQLException: not yet implemented.

When using a connection pool with the Glassfish V2 UR2 application server, this method is called. Applications work normally, but the server log gets very poluted, obfuscating useful information.

Commits: eff6a51

@firebird-automations
Copy link
Author

Commented by: Felipe Jaekel (fkj)

The application server also invokes org.firebirdsql.jdbc.FBConnection.setClientInfo(FBConnection.java:283)

@firebird-automations
Copy link
Author

Modified by: Felipe Jaekel (fkj)

Attachment: stacktrace.txt [ 11000 ]

@firebird-automations
Copy link
Author

Modified by: Roman Rokytskyy (rrokytskyy)

Fix Version: Jaybird 2.2 [ 10053 ]

@firebird-automations
Copy link
Author

Modified by: Roman Rokytskyy (rrokytskyy)

status: Open [ 1 ] => Closed [ 6 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Commented by: Riccardo Casatta (xenoky)

Hello,

i have just downloaded jaybird 2.2 from http://jaybirdwiki.firebirdsql.org/jaybird/doku.php?id=download:start#jaybird_2.2

I think this bug isn't implemented yet in this version... i get always "getClientInfo Exception". (i use glassfish v3 and the container pooled connection with org.firebirdsql.pool.sun.AppServerConnectionPoolDataSource. Firebird version is 1.5)

I also decompiled file AbstractConnection.class in the package jaybird-full-2.2.0.jar and i didn't find the getClientInfo methods.

@firebird-automations
Copy link
Author

Commented by: Opher Shachar (ophers)

Hello,
I think there are problems with the fix:
1. method setClientInfo(stmt, name, value)
should be marked 'protected' (not public) as is the case with getClientInfo(stmt, name)

2. There sould be a
finally {
rs.close;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant