Commented by: Roman Rokytskyy (rrokytskyy)

Seems that we can fix it with simply deprecating the getInternalError() method and returning the original exception as the cause. Can you please confirm this or provide a test case against which the driver can be checked?

Commented by: @mrotteveel

I will see if I can look into this in the coming week.

Commented by: Roman Rokytskyy (rrokytskyy)

A test case would be great!

Commented by: @mrotteveel

I have looked over the code and it looks OK to me. I have not created a testcase. instead I propose a patch which will greatly simplify FBSQLException and delegates more to the SQLException superclass and Throwable (obviating the need for a Firebird specific testcase as the behavior will be general Java). See the attached patch file.

What the patch does:
* Removes storing exception message in FBSQLException (delegate to superclass)
* Removes storing cause (original) in FBSQLException (delegate to superclass)
* Removes IOException specific constructor as it does not add any value (except adding 'I/O Exception ' to the message)
* Removes text 'Exception . ' from message text in (Exception ex) constructor
* Inherit (fb)errorcode in (GDSException ex) constructor
* Inherit errorcode in (String message, SQLException ex) constructor
* Remove setNextException in (String message, SQLException ex) constructor as it conflicts with the intent of the chaining (get/setNextException) : providing a way of communicating concurrent, but separate exceptions (or 'chain of events leading up to the final error')
* Remove getErrorCode() override (delegate to superclass)

Commented by: @mrotteveel

Reopen to integrate patch

Commented by: @mrotteveel

Committed patch and some additional improvements to delegate more to superclass.

Commented by: @mrotteveel

Missed two cases were the isc errorcode should be set. Committed correction.