Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatabaseMetaData getDatabaseProductName() and getDatabaseProductVersion() return illogical / incorrect information [JDBC152] #193

Closed
firebird-automations opened this issue Feb 21, 2010 · 12 comments
Closed

DatabaseMetaData getDatabaseProductName() and getDatabaseProductVersion() return illogical / incorrect information [JDBC152] #193

firebird-automations opened this issue Feb 21, 2010 · 12 comments
Assignees
@mrotteveel
Labels
affect-version: Jaybird 2.2 component: jdbc driver fix-version: Jaybird 2.2 priority: minor resolution: fixed type: bug

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Is related to JDBC115

Attachments:
Versionformat-patch.txt
Versionformat-patch-v2.txt

The result of the DatabaseMetaData methods getDatabaseProductName() and getDatabaseProductVersion() return illogical / incorrect information.

On my local machine with Firebird v2.1.3 (x64) the calls return:
Product name: Firebird 2.1-WI-V2.1.3.18185 Firebird 2.1/tcp (Ramona)/P10
Product version: WI-V2.1.3.18185 Firebird 2.1-WI-V2.1.3.18185 Firebird 2.1/tcp (Ramona)/P10

I would expect the returned information to be:
Product name: Firebird 2.1
Product version: 2.1.3.18185 (or maybe WI-V2.1.3.18185, as it also provides the platform information)

Commits: 8191f5f
@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Patch to achieve version formats as suggested (productname: Firebird 2.1, productversion: WI-V2.1.3.18185)

Did not update associated test

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Attachment: Versionformat-patch.txt [ 11585 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Just looked at TestGDSServerVersion. It looks like the version format changed between v1.5 and v2.1 (, replaced by -). Fix might need some additional work to support both formats

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

New patch that takes into account both version formats.

NOTE: This patch assumes minimum supported version is Java 1.4, as it uses java.util.regex which was introduced in 1.4.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Attachment: Versionformat-patch-v2.txt [ 11587 ]

@firebird-automations
Copy link
Author

Modified by: Roman Rokytskyy (rrokytskyy)

Fix Version: Jaybird 2.2 [ 10053 ]

timeestimate: 0 [ 0 ]

timeoriginalestimate: 0 [ 0 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Link: This issue is related to JDBC115 [ JDBC115 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Committed change to generate more sensible version and product information. This also fixes JDBC115

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
affect-version: Jaybird 2.2 component: jdbc driver fix-version: Jaybird 2.2 priority: minor resolution: fixed type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations