Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic ConnectionPoolDataSource [JDBC177] #224

Closed
firebird-automations opened this issue Jul 30, 2011 · 8 comments
Closed

Implement basic ConnectionPoolDataSource [JDBC177] #224

firebird-automations opened this issue Jul 30, 2011 · 8 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Jira_subtask_inward JDBC176

Fixing JDBC86, JDBC93, JDBC131 and JDBC144 involves a large amount of code changes with a large impact throughout Jaybird. To limit the scope of changes in Jaybird 2.2, it is better to create a simple and basic ConnectionPoolDataSource so it is usable as a workaround for problems experienced with the following classes:
* FBConnectionPoolDataSource
* DriverConnectionPoolDataSource
* AppServerConnectionPoolDataSource

The documentation of above classes should be updated to notify users of the bugs in the implementation and point to the new implementation as a workaround. For Jaybird after 2.2 these classes should then either be fixed or removed (decision pending further analysis).

Requirements for the implementation of ConnectionPoolDataSource:
* Implement as described in JDBC 3.0 / JDBC 4.0 (either in one class or as two separate implementations)
* Implement with minimal properties
* No internal connection pooling

Commits: 628e86f f050579

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.2 [ 10053 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Committed initial implementation. I still need to include JNDI specific stuff (oa Referenceable). Current implementation has not been tested in an AS yet.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Added implementation for Referenceable.

Tested in GlassFish 3.1 (with and without Referenceable implementation): datasource working as expected, also ran testcase of JDBC93 without problems.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Marked old ConnectionPoolDataSources as broken and pointed to org.firebirdsql.ds.FBConnectionPoolDataSource as its replacement.

It looks like FBWrappingDataSource will not be influenced by this bug, as it uses the PooledConnection only once and leaves the pool management itself to the old ConnectionPoolDataSource implementation (in org.firebirdsql.pool.FBConnectionPoolDataSource; so there is no conflict.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants