New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic ConnectionPoolDataSource [JDBC177] #224
Comments
Modified by: @mrotteveelassignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ] |
Modified by: @mrotteveelFix Version: Jaybird 2.2 [ 10053 ] |
Modified by: @mrotteveelstatus: Open [ 1 ] => In Progress [ 3 ] |
Commented by: @mrotteveel Committed initial implementation. I still need to include JNDI specific stuff (oa Referenceable). Current implementation has not been tested in an AS yet. |
Commented by: @mrotteveel Added implementation for Referenceable. Tested in GlassFish 3.1 (with and without Referenceable implementation): datasource working as expected, also ran testcase of JDBC93 without problems. |
Commented by: @mrotteveel Marked old ConnectionPoolDataSources as broken and pointed to org.firebirdsql.ds.FBConnectionPoolDataSource as its replacement. It looks like FBWrappingDataSource will not be influenced by this bug, as it uses the PooledConnection only once and leaves the pool management itself to the old ConnectionPoolDataSource implementation (in org.firebirdsql.pool.FBConnectionPoolDataSource; so there is no conflict. |
Modified by: @mrotteveelstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @mrotteveel
Jira_subtask_inward JDBC176
Fixing JDBC86, JDBC93, JDBC131 and JDBC144 involves a large amount of code changes with a large impact throughout Jaybird. To limit the scope of changes in Jaybird 2.2, it is better to create a simple and basic ConnectionPoolDataSource so it is usable as a workaround for problems experienced with the following classes:
* FBConnectionPoolDataSource
* DriverConnectionPoolDataSource
* AppServerConnectionPoolDataSource
The documentation of above classes should be updated to notify users of the bugs in the implementation and point to the new implementation as a workaround. For Jaybird after 2.2 these classes should then either be fixed or removed (decision pending further analysis).
Requirements for the implementation of ConnectionPoolDataSource:
* Implement as described in JDBC 3.0 / JDBC 4.0 (either in one class or as two separate implementations)
* Implement with minimal properties
* No internal connection pooling
Commits: 628e86f f050579
The text was updated successfully, but these errors were encountered: