Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure setting nonStandardProperty works for replacement datasources [JDBC184] #232

Closed
firebird-automations opened this issue Sep 3, 2011 · 7 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Jira_subtask_inward JDBC176

See mail discussion in Firebird-Java re Jaybird 2.2:

Quote from Roman:
"I have implemented the nonStandardProperty setters in the old pool
code. The idea was that to create getters/setters for each DPB property
would be an overkill, so it accepted a text "property=value" and passed
that text below to the driver level. The same code was used to parse the
non-standard properties on the pool level and in JDBC url."

Commits: acc2c37 94b3643

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.2 [ 10053 ]

description: See mail discussion in Firebird-Java re Jaybird 2.2:

Quote from Roman:
"I have implemented the nonStandardProperty setters in the old pool
code. The idea was that to create getters/setters for each DPB property
would be an overkill, so it accepted a text "property=value" and passed
that text below to the driver level. The same code was used to parse the
non-standard properties on the pool level and in JDBC url."

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Component: Connection pool [ 10054 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Added setNonStandardProperty(string) as is used on AbstractFBConnectionPoolDataSource, changed Referenceable implementation to serialize / deserialize the connectionProperties.

Need to add test to verify.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Added test for set and retrieving nonStandardProperty; also implicitly tested by TestDataSourceFactory

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants