Queries on a newly created database fail if that is the first and only attachment [JDBC190] #238
Comments
Modified by: @mrotteveelassignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ] |
Modified by: @mrotteveelstatus: Open [ 1 ] => In Progress [ 3 ] |
Modified by: @mrotteveel |
Modified by: @mrotteveeldescription: In JDBC185 a number of tests in org.firebirdsql.gds.impl.wire.TestGds failed under Java 7, as the execution order was changed. This same test failure is reproducible if the affected tests are executed in isolation on Java 6. I have identified that the following tests fail (with the same error) when run independently: If these tests are preceded by any one of the following tests it does work: The difference seems to be that the failing tests only call iscCreateDatabase and use the database handle, while the other tests also call iscAttachDatabase. Looking over the code it seems that iscCreateDatabase and iscAttachDatabase could (and should) share the same code (except for sending op_create instead of op_attach). In iscAttachDatabase, based on the version of the connected database, infobuffers are set for iscDsqlPrepare and iscDescribe / iscDescribeBind. These buffers are set as instance variables of AbstractJavaGDSImpl. This has two problems : Solution: => In JDBC185 a number of tests in org.firebirdsql.gds.impl.wire.TestGds failed under Java 7, as the execution order was changed. This same test failure is reproducible if the affected tests are executed in isolation on Java 6. The error produced by the failing tests is: I have identified that the following tests fail (with the same error) when run independently: If these tests are preceded by any one of the following tests it does work: The difference seems to be that the failing tests only call iscCreateDatabase and use the database handle, while the other tests also call iscAttachDatabase. Looking over the code it seems that iscCreateDatabase and iscAttachDatabase could (and should) share the same code (except for sending op_create instead of op_attach). In iscAttachDatabase, based on the version of the connected database, infobuffers are set for iscDsqlPrepare and iscDescribe / iscDescribeBind. These buffers are set as instance variables of AbstractJavaGDSImpl. This has two problems : Solution: |
Modified by: @mrotteveeldescription: In JDBC185 a number of tests in org.firebirdsql.gds.impl.wire.TestGds failed under Java 7, as the execution order was changed. This same test failure is reproducible if the affected tests are executed in isolation on Java 6. The error produced by the failing tests is: I have identified that the following tests fail (with the same error) when run independently: If these tests are preceded by any one of the following tests it does work: The difference seems to be that the failing tests only call iscCreateDatabase and use the database handle, while the other tests also call iscAttachDatabase. Looking over the code it seems that iscCreateDatabase and iscAttachDatabase could (and should) share the same code (except for sending op_create instead of op_attach). In iscAttachDatabase, based on the version of the connected database, infobuffers are set for iscDsqlPrepare and iscDescribe / iscDescribeBind. These buffers are set as instance variables of AbstractJavaGDSImpl. This has two problems : Solution: => In JDBC185 a number of tests in org.firebirdsql.gds.impl.wire.TestGds failed under Java 7, as the execution order was changed. This same test failure is reproducible if the affected tests are executed in isolation on Java 6. The error produced by the failing tests is: I have identified that the following tests fail (with the same error) when run independently: If these tests are preceded by any one of the following tests it does work: The difference seems to be that the failing tests only call iscCreateDatabase and use the database handle, while the other tests also close the database handle from the create, and then create a new attachment by calling iscAttachDatabase. Looking over the code it seems that iscCreateDatabase and iscAttachDatabase could (and should) share the same code (except for sending op_create instead of op_attach). In iscAttachDatabase, based on the version of the connected database, infobuffers are set for iscDsqlPrepare and iscDescribe / iscDescribeBind. These buffers are set as instance variables of AbstractJavaGDSImpl. This has two problems : Solution: |
|
Commented by: @mrotteveel Initially implementation using dynamic decision in my workspace. Contemplating to change this to member variables. |
Modified by: @mrotteveelFix Version: Jaybird 2.2 [ 10053 ] |
|
Commented by: @mrotteveel Decided to keep the dynamic decision; in the future we might want to restructure the wire protocol implementation to make it more OO and less procedural. |
Modified by: @mrotteveelstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @mrotteveel
Is related to JDBC185
In JDBC185 a number of tests in org.firebirdsql.gds.impl.wire.TestGds failed under Java 7, as the execution order was changed. This same test failure is reproducible if the affected tests are executed in isolation on Java 6.
The error produced by the failing tests is:
org.firebirdsql.gds.GDSException: SQLDA missing or incorrect version, or incorrect number/type of variables
at org.firebirdsql.gds.impl.wire.AbstractJavaGDSImpl.parseTruncSqlInfo(AbstractJavaGDSImpl.java:2633)
at org.firebirdsql.gds.impl.wire.AbstractJavaGDSImpl.parseSqlInfo(AbstractJavaGDSImpl.java:2468)
at org.firebirdsql.gds.impl.wire.AbstractJavaGDSImpl.iscDsqlPrepare(AbstractJavaGDSImpl.java:1604)
at org.firebirdsql.gds.impl.wire.AbstractJavaGDSImpl.iscDsqlPrepare(AbstractJavaGDSImpl.java:1559)
at org.firebirdsql.gds.impl.wire.AbstractJavaGDSImpl.iscDsqlPrepare(AbstractJavaGDSImpl.java:1551)
at org.firebirdsql.gds.impl.wire.TestGds.testCreateAndWriteBlobStreamInSegmentedPieces(TestGds.java:713)
I have identified that the following tests fail (with the same error) when run independently:
* testPreparedSelect
* testCreateAndWriteBlob
* testCreateAndWriteBlobStream
* testCreateAndWriteBlobStreamInSegmentedPieces
If these tests are preceded by any one of the following tests it does work:
* testCreateDropDB
* testCreateDropD3DB
* testDbHandleEquality
The difference seems to be that the failing tests only call iscCreateDatabase and use the database handle, while the other tests also close the database handle from the create, and then create a new attachment by calling iscAttachDatabase. Looking over the code it seems that iscCreateDatabase and iscAttachDatabase could (and should) share the same code (except for sending op_create instead of op_attach).
In iscAttachDatabase, based on the version of the connected database, infobuffers are set for iscDsqlPrepare and iscDescribe / iscDescribeBind. These buffers are set as instance variables of AbstractJavaGDSImpl. This has two problems :
1) If iscCreateDatabase is called these are not set, so results of PreparedStatements and such fail
2) As AbstractJavaGDSImpl is a 'sort-of' Singleton the values of the infobuffers set by the last call to iscAttachDatabase are used for all connections; this can be especially problematic when connecting to both Firebird 1.5 and Firebird 2.x databases.
Solution:
Make sure iscCreateDatabase and iscAttachDatabase share the same implementation, the infobuffers either need to be decided on dynamically (based on the implementation version of the db attachment), or these infobuffers should be made member variables of isc_db_handle_impl.
Commits: c79c562
The text was updated successfully, but these errors were encountered: