Commented by: @mrotteveel

Added columns to metadata. The getProcedureColumns needs some ODS specific retrieval of information. Also need to investigate the intention of some of the columns (eg ORDINAL_POSITION of getProcedureColumns has a vague description).

The index of OWNER_NAME in getTables() has changed as this column is Jaybird specific and not defined in JDBC.

Also need to check other methods for missing columns.

Commented by: @mrotteveel

Extra tests for metadata are required as well: I forgot to increase some array sizes.

Commented by: @mrotteveel

Added test for getColumns()

During writing the tests I also made the following changes:
* Added BIGINT support to COLUMN_SIZE, NUM_PREC_RADIX and DECIMAL_DIGITS (as it was missing)
* Column SCOPE_CATLOG if JDBC 4.0 or earlier, SCOPE_CATALOG in JDBC 4.1 and higher (gotta love standards fixing 'typos')
* Column BUFFER_LENGTH is now actual NULL instead of actual 0
* Column DECIMAL_DIGITS is actual NULL for all types except NUMERIC, DECIMAL (value equals scale), and BIGINT, INTEGER and SMALLINT (value is actual 0) as defined in SQL 2003 Schemata definition (this includes DOUBLE PRECISION and FLOAT having it NULL!)
* Column NUM_PREC_RADIX is 10 only for integral, fixed point and floating point types, actual NULL for all others
* Column CHAR_OCTET_LENGTH is only set for CHAR and VARCHAR and is actual NULL for all other datatypes
* Column IS_AUTOINCREMENT also returns "" (unknown) for NUMERIC and DECIMAL with scale 0, explicit "NO" for scale != 0
* Determining java.sql.Types value for DATA_TYPE and name for TYPE_NAME for NUMERIC and DECIMAL no longer looks at scale, only at actual subtype
* Added NUMERIC/DECIMAL determination of TYPE_NAME for Firebird type smallint (type 7) as it was missing (was present for DATA_TYPE)

Commented by: @mrotteveel

Added support for IS_GENERATEDCOLUMN (which identifies COMPUTED BY / GENERATED ALWAYS AS columns), rewrote getColumns() metadata tests to reduce duplication and potential for typing errors.

Commented by: @mrotteveel

Update getColumns() metadata + refactored some things for other (future0 metadata tests
Added tests for getTables() : work in progress

I need to research the exact treatment of quoted vs unquoted identifiers in JDBC, as the standard is opaque about the following:
* Should TABLE_NAME (and COLUMN_NAME for that matter) returning the table cq column name quoted or unquoted (current implementation returns unquoted as they are stored unquoted)
* Should the tableNamePattern and columnNamePattern be quoted or unquoted when searching for quoted identifiers (current implementation requires quoted, but the JDBC spec says "tableNamePattern - a table name pattern; must match the table name as it is stored in the database" and as it is, they are stored unquoted in their original case.

Commented by: @mrotteveel

* Added test for getUDTs()
* fixed getUDTs() DATA_TYPE column type (from VARCHAR to INTEGER), apparently the JDBC 2.0 specified the wrong column type (was String, changed to int in JDBC 3.0)
* Fixed column index mistake I made when adding the BASE_TYPE column to getUDTs()

Commented by: @mrotteveel

* Added tests for getProcedures()
* Fixed case where empty string is passed as procedureNamePattern to bring it in line with behaviour of getColumns() and getTables()

Commented by: @mrotteveel

* Made some changes to getProcedureColumns to comply with expectations defined in JDBC spec and javadoc
** Include value for CHARACTER_OCTET_LENGTH (if CHAR and VARCHAR)
** Include value for ORDINAL_POSITION
** Changed setting PRECISION, SCALE and RADIX to be in line with JDBC spec (and behavior in getColumns())
* Added some TODOs for things that require further research (value of COLUMN_TYPE see JDBC229 + some other things)
* Added basic tests for getProcedureColumns

Commented by: @mrotteveel

Procedures listed in this ticket have been updated. Created JDBC230 to add tests for other resultset-producing metadata methods in the future.

Commented by: @mrotteveel

Some of the changes I made use CASE WHEN, this was introduced with Firebird 1.5; rewrite so that Jaybird continues working with Firebird 1.0

Commented by: @mrotteveel

Removed CASE constructs from metadata queries