Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JUnit tests to JUnit 4 [JDBC201] #250

Closed
firebird-automations opened this issue Nov 20, 2011 · 8 comments
Closed

Migrate JUnit tests to JUnit 4 [JDBC201] #250

firebird-automations opened this issue Nov 20, 2011 · 8 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Migrate the existing tests from JUnit 3 to JUnit 4, and use the new features to have tighter control on the tests executed or skipped (instead of using a list in build/test.xml).

Commits: 358e024 4a752bd 2470f11 5b74070

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

For Jaybird 2.3 switch to JUnit 4, but only upgrade tests to JUnit 4 where needed (JUnit 3 tests should run without trouble under JUnit 4).

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Changed prio to critical as doing this early so new tests can take advantage of JUnit 4 features.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

priority: Minor [ 4 ] => Critical [ 2 ]

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Refactored SimpleFBTestBase to FBTestProperties, no longer inheriting from TestCase, moved a large number of test property related methods and factory methods from FBTestBase to FBTestProperties. Moved several helper methods for test DDL and closing JDBC resources to separate helper classes.

Introduced FBJUnit4TestBase with similar setup as FBTestBase and converted TestFBSavePoint to a JUnit 4 test.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

From now on, tests should be written in JUnit 4, but I didn't mark FBTestBase as deprecated to prevent a hundred annoying deprecation warnings. Moving existing tests over to JUnit 4 will only happen if it is either necessary or if the test-class is undergoing major changes.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants