Refactor IscDbHandle descendants [JDBC206] #255
Comments
Modified by: @mrotteveelassignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ] |
Modified by: @mrotteveelstatus: Open [ 1 ] => In Progress [ 3 ] |
|
Commented by: @mrotteveel Moved common methods to AbstractIscDbHandle, and added methods commonly used by casting down from IscDbHandle to AbstractIscDbHandle or lower to the IscDbHandle interface definition. As code in isc_db_handle_impl is in LGPL, I changed the license of AbstractIscDbHandle to LGPL. This is no problem as the 'interface' that was under BSD in AbstractIscDbHandle is now part of IscDbHandle (which is BSD). |
|
Commented by: @mrotteveel Removed a number of casts that are no longer necessary. There are some more places where these could be removed, but as these involve the JNI and pure-java implementation, casts to the right isc_db_handle_impl might actually be the right course of action to ensure the right types are used (no mixing of native and pure-java). This does seem to indicate a bit of additional refactoring work may be required there. I will need to look into that a bit more for later Jaybird versions. |
Modified by: @mrotteveelstatus: In Progress [ 3 ] => Open [ 1 ] |
Modified by: @mrotteveelFix Version: Jaybird 2.2 [ 10053 ] |
Modified by: @mrotteveelstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @mrotteveel
Both the JNI and pure-java implementation of IscDbHandle share a lot of similar or same code. Pull the implementation of methods up to AbstractIscDbHandle.
Also a lot of the methods defined in AbstractIscDbHandle and in both isc_db_handle_impl variants are used by casting a IscDbHandle to AbstractIscDbHandle (or even isc_db_handle_impl) for example in GDSHelper and FBManagedConnection (and Factory + MetaData). This indicates that they should be defined in IscDbHandle instead.
Commits: 6d04361 53f985c 2d7bcb5 e602f0a
The text was updated successfully, but these errors were encountered: