Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Jaybird interfaces [JDBC211] #260

Closed
firebird-automations opened this issue Dec 18, 2011 · 6 comments
Closed

Cleanup Jaybird interfaces [JDBC211] #260

firebird-automations opened this issue Dec 18, 2011 · 6 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Jaybird contains a number of interfaces that were defined to provide compatibility/functionality of higher JDBC versions. Some of these are no longer required because the minimum supported JDBC version contains all this functionality.

The following interfaces can either be removed or require cleanup (removal of methods already defined in JDBC interfaces):
* FirebirdSavepoint (remove completely)
* FirebirdConnection (remove methods)
** setFirebirdSavepoint() replace with Connection#⁠setSavepoint()
** setFirebirdSavepoint(String name) replace with Connection#⁠setSavepoint(String name)
** rollback(FirebirdSavepoint savepoint) replace with Connection#⁠rollback(Savepoint savepoint)
** releaseSavepoint(FirebirdSavepoint savepoint) replace with Connection#⁠releaseSavepoint(Savepoint savepoint)

(list is work in progress)

Commits: 11a5b3f

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

description: Jaybird contains a number of interfaces that were defined to provide compatibility/functionality of higher JDBC versions. Some of these are no longer required because the minimum supported JDBC version contains all this functionality.

The following interfaces can either be removed or require cleanup (removal of methods already defined in JDBC interfaces):
* FirebirdSavepoint

(list is work in progress)

=>

Jaybird contains a number of interfaces that were defined to provide compatibility/functionality of higher JDBC versions. Some of these are no longer required because the minimum supported JDBC version contains all this functionality.

The following interfaces can either be removed or require cleanup (removal of methods already defined in JDBC interfaces):
* FirebirdSavepoint (remove completely)
* FirebirdConnection (remove methods)
** setFirebirdSavepoint() replace with Connection#⁠setSavepoint()
** setFirebirdSavepoint(String name) replace with Connection#⁠setSavepoint(String name)
** rollback(FirebirdSavepoint savepoint) replace with Connection#⁠rollback(Savepoint savepoint)
** releaseSavepoint(FirebirdSavepoint savepoint) replace with Connection#⁠releaseSavepoint(Savepoint savepoint)

(list is work in progress)

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Extension interfaces will not be removed, but will simply be empty if there are no additional methods besides the ones defined in JDBC.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Removed FirebirdSavepoint specific methods from FirebirdConnection and AbstractConnection.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants