Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FBStatementFactory seems to be unnecessary, remove it? [JDBC212] #261

Closed
firebird-automations opened this issue Dec 18, 2011 · 7 comments
Closed

FBStatementFactory seems to be unnecessary, remove it? [JDBC212] #261

firebird-automations opened this issue Dec 18, 2011 · 7 comments
Assignees
@mrotteveel
Labels
component: jdbc driver fix-version: Jaybird 3.0.0 priority: trivial resolution: fixed type: task

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

The FBStatementFactory seems to be unnecessary, as the classes involved could be called by their constructor directly. Remove it to eliminate construction through reflection

Commits: a170aa1
@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.3 [ 10440 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

I guess this might have been a workaround for compilation problems as the classes loaded this way have a JDBC version specific implementation. After elimination of FBStatementFactory and ClassFactory it continues to work. The only potential snag might be the behaviour in situations with multiple classloaders; I need to investigate this further before committing.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Comments from the introduction of these classes and the code before the introduction seem to indicate this was solely for the JDK specific versions. I am unsure if previous versions of Java had problems compiling this. I don't think classloading issues are involved.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Removed FBStatementFactory, GDSObjectFactory and ClassFactory

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
component: jdbc driver fix-version: Jaybird 3.0.0 priority: trivial resolution: fixed type: task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations