Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native implementation of isc_dsql_describe incorrectly calls isc_dsql_describe_bind [JDBC234] #283

Closed
firebird-automations opened this issue Feb 9, 2012 · 5 comments
Closed

Native implementation of isc_dsql_describe incorrectly calls isc_dsql_describe_bind [JDBC234] #283

firebird-automations opened this issue Feb 9, 2012 · 5 comments
Assignees
@mrotteveel
Labels
affect-version: Jaybird 2.2 component: jni/jna layer fix-version: Jaybird 2.2 priority: major resolution: fixed type: bug

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

I was going over the native sources when I noticed that Java_org_firebirdsql_gds_impl_jni_JniGDSImpl_native_1isc_1dsql_1describe calls isc_dsql_describe_bind instead of isc_dsql_describe in this piece of code in entrypoints.cpp:

    CALL\_API\(isc\_dsql\_describe\)\( status\.RawAccess\(\), &rawStatementHandle, jDaVersion, xsqlda\.RawAccess\(\) \);

    xsqlda\.Resize\( xsqlda\.RawAccess\(\)\-\>sqld \);

    CALL\_API\(isc\_dsql\_describe\_bind\)\( status\.RawAccess\(\), &rawStatementHandle, jDaVersion, xsqlda\.RawAccess\(\) \);

The second call should be isc_dsql_describe

Commits: f70bd00
@firebird-automations
Copy link
Author

Modified by: @mrotteveel

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Version: Jaybird 2.2 [ 10053 ]

Fix Version: Jaybird 2.2 [ 10053 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Changed implementation to call isc_dsql_describe again.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
affect-version: Jaybird 2.2 component: jni/jna layer fix-version: Jaybird 2.2 priority: major resolution: fixed type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations