Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if geronimo dependency listed in Maven works correctly for Jaybird [JDBC244] #293

Closed
firebird-automations opened this issue Mar 11, 2012 · 9 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Is related to JDBC114

According to JDBC114 and http://stackoverflow.com/questions/9646883/dependences-for-firebird-jaybird-and-hibernate (see comment on my answer) the maven dependency (geronimo) used as a replacement for the mini-j2ee.jar doesn't (always?) work, this needs to be investigated.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

assignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Link: This issue is related to JDBC114 [ JDBC114 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Ran testsuite using the geronimo dependency and all tests pass. Did some more searching and found:
http://tomcat.apache.org/tomcat-7.0-doc/class-loader-howto.html :
> Last, any JAR file that contains Servlet API classes will be explicitly ignored by the classloader

As the geronimo dependency includes the entire J2EE spec, it is not loaded by the Tomcat classloader, this means there are the following potential solution:
* Release the jaybird-full package as well
* Release mini-j2ee.jar as a dependency
* Use groupId: javax.resource, artifactId: connector and version: 1.0 as dependency and leave people to get it themselves some way (eg by including http://download.java.net/maven/2/ repository)
* Use groupId: javax.resource, artifactId connector-api version 1.6-alpha-1 (as that is in Maven central)

This last one might be the easiest, but might give unexpected problems as Jaybird implements JCA 1.0

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.2 [ 10053 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

It looks like the 1.5 connector-api is also available on maven central

@firebird-automations
Copy link
Author

Commented by: Roman Rokytskyy (rrokytskyy)

I think that releasing the jaybird-full package is a good idea. I am not sure about releasing mini-j2ee.jar, since it is "yet another j2ee jar" and will only confuse people.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Switched to connector-api-1.5. We will release the 'normal' jaybird.jar to Maven with connector-api 1.5 specified as a dependency.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment