Commented by: @mrotteveel

Where is FBConnectionProperties being used as a key to a Map / HashTable? I quickly scanned to code, but couldn't find it.

Commented by: @alexeykovyazin

sorry for incomplete description

FBConnectionProperties is not used as a key, key is instance of FBManagedConnectionFactory mcf
method AbstractDriver.createDataSource

private FBDataSource createDataSource(FBManagedConnectionFactory mcf) throws ResourceException {
FBDataSource dataSource = null;
synchronized (mcfToDataSourceMap)
{
dataSource = (FBDataSource)mcfToDataSourceMap.get(mcf);

       if \(dataSource == null\) \{
           dataSource = \(FBDataSource\)mcf\.createConnectionFactory\(\);
           mcfToDataSourceMap\.put\(mcf, dataSource\);
       \}
   \}
   return dataSource;

}

and FBManagedConnectionFactory in the implementation of equals/hashCode uses FBConnectionProperties.equals/hashCode

Commented by: @mrotteveel

It looks like removing mapper from hashCode and equals, and make sure the defaultIsolation is recorded in FBConnectionProperties if it is changed will fix this specific problem.
However I think the hashCode of FBConnectionProperties is inherently unstable: if one of the values recorded in the internal HashMap properties is changed or the value of type, database, tpbMapping or defaultTransactionIsolation is changed. This may require more thinking to get right.

Limiting the hashCode to database and type could be good enough and leave the rest to equals. I will need to research and test this a little bit longer.

Commented by: @mrotteveel

Committed fix; I reduced the hashCode calculation to the most stable fields so it should remain stable. Also fixed a potential thread safety issue.

I also changed the storage of mcfToDataSourceMap to a WeakHashMap to prevent a potential different memory leak, but I am not 100% sure if that worked (limited testing did not reveal it getting garbage collected).

Commented by: @mrotteveel

Fixed for Jaybird-2.2 after beta-1