Decisions on charactersets happen in to many places [JDBC269] #316
Assignees
Comments
Modified by: @mrotteveelassignee: Roman Rokytskyy [ rrokytskyy ] => Mark Rotteveel [ avalanche1979 ] |
Modified by: @mrotteveelFix Version: Jaybird 3.0 [ 10440 ] |
|
Commented by: @mrotteveel Most of the encoding information has been moved to Encoding and related factories, the impact of these changes still needs to be documented. There are still a number of changes that could improve this further, but I will defer that to a future version. |
Modified by: @mrotteveelstatus: Resolved [ 5 ] => Closed [ 6 ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Submitted by: @mrotteveel
There are too many places in the Jaybird code were decisions on charactersets are made; some parts retrieve a new instance of the Encoding implementation for the connection characterset whenever it needs it, instead of storing it once and reusing it.
Potential improvements:
* Factor some parts of EncodingFactory to a separate class to act as 'the characterset' (including things like getIscEncodingSize and getEncoding)
* Have the connection keep the instance of its connection characterset so it is available for reuse
* ...
Commits: 4bffb5e b1c9bd9
The text was updated successfully, but these errors were encountered: