[#JDBC-285] JNI implementation of parameter buffer writes incorrect integers

Jaybird JCA/JDBC Driver

JNI implementation of parameter buffer writes incorrect integers

Created: 02/Dec/12 08:36 AM Updated: 21/Feb/13 08:08 PM

Component/s:

JNI layer

Affects Version/s:

Jaybird 2.1.6, Jaybird 2.2, Jaybird 2.2.1

Fix Version/s:

Jaybird 2.2.2, Jaybird 2.3

Time Tracking:

Issue & Sub-Tasks

Issue Only

Not Specified

Issue Links:

Relate

This issue relate to:

~~JDBC-284~~ Connection properties definition not processed correctly

This issue is related to:

~~JDBC-286~~ DPB and SPB format are different

Sub-Tasks:

All

Open

~~Refactor parameterbuffer implementations to reduce code duplication~~

Closed

Mark Rotteveel

Description

« Hide

The JNI parameterbuffer implemention (org.firebirdsql.gds.impl.jni.ParameterBufferBase, specifically inner class NumericArgument) writes integers incorrectly. Instead of prefixing the length in bytes, it simply writes the 4 bytes of the value. This probably wasn't noticed before because of ~~JDBC-284~~, and the fact that the only other int-property was an extension property which is never written out to the buffer.

Also the gds.impl.jni and gds.impl.wire versions of these classes are almost identical (if not identical): refactor to a common base class.

All

Comments

Work Log

Change History

Version Control

Subversion Commits

Sort Order:

[ Permalink | « Hide ]

Mark Rotteveel added a comment - 02/Dec/12 08:37 AM

Refactor action only for Jaybird 2.3, fix also for Jaybird 2.2.2

[ Permalink | « Hide ]

Mark Rotteveel added a comment - 02/Dec/12 10:53 AM - edited

It would be a good idea to restructe the ParameterBuffer implementation hierarchy to be similar to the implementation in the .NET provider, that will result in a lot less duplication of code.