New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holdable ResultSet is closed on autocommit [JDBC305] #351
Comments
Commented by: @mrotteveel Tentatively scheduled for 2.2.3, may need to defer some work to 2.3 as it is not a good idea to tear up the existing structure in a point release. |
Modified by: @mrotteveelFix Version: Jaybird 2.2.3 [ 10510 ] |
Modified by: @mrotteveel |
Modified by: @mrotteveel |
Modified by: @mrotteveeldescription: A holdable ResultSet is closed on commit, it should remain open. This is related to JDBC304 where in 2.2.x no rows can be retrieved from a holdable ResultSet after commit. The logic surrounding statement completion, commits etc in the driver spreads responsibility around too much (eg the transaction coordinator needs to know what happens with statements, Statement needs to know what should happen with the ResultSet and vice versa). This may need to be reworked in an observer pattern to decouple this. => A holdable ResultSet is closed on commit (during autocommit), it should remain open. This is related to JDBC304 where in 2.2.x no rows can be retrieved from a holdable ResultSet after commit. The logic surrounding statement completion, commits etc in the driver spreads responsibility around too much (eg the transaction coordinator needs to know what happens with statements, Statement needs to know what should happen with the ResultSet and vice versa). This may need to be reworked in an observer pattern to decouple this. |
Modified by: @mrotteveel |
Modified by: @mrotteveelsummary: Holdable ResultSet is closed on commit => Holdable ResultSet is closed on autocommit |
Commented by: @mrotteveel Changes made for JDBC304 fix this problem. More radical changes will be done as part of JDBC307 for Jaybird 2.3 |
Modified by: @mrotteveelFix Version: Jaybird 2.3 [ 10440 ] |
Modified by: @mrotteveelstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @mrotteveel
Is related to JDBC304
Is related to JDBC209
Relate to JDBC307
A holdable ResultSet is closed on commit (during autocommit), it should remain open. This is related to JDBC304 where in 2.2.x no rows can be retrieved from a holdable ResultSet after commit.
The logic surrounding statement completion, commits etc in the driver spreads responsibility around too much (eg the transaction coordinator needs to know what happens with statements, Statement needs to know what should happen with the ResultSet and vice versa). This may need to be reworked in an observer pattern to decouple this.
Commits: 68fa2d2 72ff1fd FirebirdSQL/fbt-repository@611977c FirebirdSQL/fbt-repository@005e6c5
The text was updated successfully, but these errors were encountered: