Issue Details (XML | Word | Printable)

Key: JDBC-315
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Mark Rotteveel
Reporter: Mark Rotteveel
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Jaybird JCA/JDBC Driver

FBConnectionProperties.setCharSet encoding issue

Created: 13/Jul/13 09:26 AM   Updated: 08/Dec/13 09:47 PM
Component/s: JDBC driver
Affects Version/s: Jaybird 2.2.3
Fix Version/s: Jaybird 2.2.4, Jaybird 3.0

Time Tracking:
Not Specified


 Description  « Hide
While working on JDBC-314, I noticed that the code did the following in FBConnectionProperties.setCharSet(...):

String encoding = getStringProperty(LOCAL_ENCODING_PROPERTY);
if (encoding != null)
return;

encoding = EncodingFactory.getIscEncoding(charSet);

if (encoding != null)
setStringProperty(ENCODING_PROPERTY, encoding);

Given what this code is supposed to do (set the Firebird encoding to match the java charSet if the Firebird encoding wasn't already set, see also the reverse code in setEncoding(...)), the first statement should be:
String encoding = getStringProperty(ENCODING_PROPERTY);

 All   Comments   Work Log   Change History   Version Control   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Mark Rotteveel added a comment - 13/Jul/13 09:27 AM
Scheduled for 2.2.4 and 2.3. Solution for 2.3 will initially be committed to the wire protocol improvements branch as I am currently overhauling the character set / encoding implementation for Jaybird 2.3