You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if (encoding != null)
setStringProperty(ENCODING_PROPERTY, encoding);
Given what this code is supposed to do (set the Firebird encoding to match the java charSet if the Firebird encoding wasn't already set, see also the reverse code in setEncoding(...)), the first statement should be:
String encoding = getStringProperty(ENCODING_PROPERTY);
Scheduled for 2.2.4 and 2.3. Solution for 2.3 will initially be committed to the wire protocol improvements branch as I am currently overhauling the character set / encoding implementation for Jaybird 2.3
Submitted by: @mrotteveel
While working on JDBC314, I noticed that the code did the following in FBConnectionProperties.setCharSet(...):
String encoding = getStringProperty(LOCAL_ENCODING_PROPERTY);
if (encoding != null)
return;
encoding = EncodingFactory.getIscEncoding(charSet);
if (encoding != null)
setStringProperty(ENCODING_PROPERTY, encoding);
Given what this code is supposed to do (set the Firebird encoding to match the java charSet if the Firebird encoding wasn't already set, see also the reverse code in setEncoding(...)), the first statement should be:
String encoding = getStringProperty(ENCODING_PROPERTY);
Commits: a3c3ef1 FirebirdSQL/fbt-repository@22d2722 FirebirdSQL/fbt-repository@a691022
The text was updated successfully, but these errors were encountered: