Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executeUpdate with RETURN_GENERATED_KEYS should return update count instead of -1 [JDBC351] #393

Closed
firebird-automations opened this issue Apr 28, 2014 · 6 comments
Closed

executeUpdate with RETURN_GENERATED_KEYS should return update count instead of -1 [JDBC351] #393

firebird-automations opened this issue Apr 28, 2014 · 6 comments
Assignees
@mrotteveel
Labels
affect-version: Jaybird 2.1.6 affect-version: Jaybird 2.2 affect-version: Jaybird 2.2.1 affect-version: Jaybird 2.2.2 affect-version: Jaybird 2.2.3 affect-version: Jaybird 2.2.4 affect-version: Jaybird 2.2.5 component: jdbc driver fix-version: Jaybird 3.0.0 priority: major resolution: fixed type: bug

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

executeUpdate with RETURN_GENERATED_KEYS should return update count instead of -1

See test org.firebirdsql.jdbc.TestFBStatementGeneratedKeys#⁠testExecuteUpdate_INSERT_returnGeneratedKeys_withReturning() (and other testExecuteUpdate_* tests)

Commits: 6d073cd
@firebird-automations
Copy link
Author

Modified by: @mrotteveel

description: executeUpdate with RETURN_GENERATED_KEYS should return update count instead of -1

See test org.firebirdsql.jdbc.TestFBStatementGeneratedKeys#⁠testExecuteUpdate_INSERT_returnGeneratedKeys_withReturning()

=>

executeUpdate with RETURN_GENERATED_KEYS should return update count instead of -1

See test org.firebirdsql.jdbc.TestFBStatementGeneratedKeys#⁠testExecuteUpdate_INSERT_returnGeneratedKeys_withReturning() (and other testExecuteUpdate_* tests)

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Fixed in trunk with new handling of return generated keys. Needs additional test coverage.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Added extra assertions

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
affect-version: Jaybird 2.1.6 affect-version: Jaybird 2.2 affect-version: Jaybird 2.2.1 affect-version: Jaybird 2.2.2 affect-version: Jaybird 2.2.3 affect-version: Jaybird 2.2.4 affect-version: Jaybird 2.2.5 component: jdbc driver fix-version: Jaybird 3.0.0 priority: major resolution: fixed type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations