You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The protocol implementation rewrite has (potentially) broken connection error signalling in FBManagedConnection. Previously some methods were routed through GDSHelper which wrapped them in a try-catch to signal (connection) errors to FBManagedConnection.
Due to refactoring and (currently partial) removal of GDSHelper this signalling is now missing in some areas. We need to handle this in the http://gds.ng implementation classes.
The text was updated successfully, but these errors were encountered:
Wrapped all public methods in try-catch that signal listeners and rethrow the exception. Chose this over proxies, compile-time rewriting, or bytecode manipulation to give the least surprise; the downside is that this requires manual code, and implementations of the interfaces need to be careful to add this.
Submitted by: @mrotteveel
The protocol implementation rewrite has (potentially) broken connection error signalling in FBManagedConnection. Previously some methods were routed through GDSHelper which wrapped them in a try-catch to signal (connection) errors to FBManagedConnection.
Due to refactoring and (currently partial) removal of GDSHelper this signalling is now missing in some areas. We need to handle this in the http://gds.ng implementation classes.
The text was updated successfully, but these errors were encountered: