Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBSQLException does not contain the custom error message [JDBC385] #427

Closed
firebird-automations opened this issue Mar 19, 2015 · 7 comments

Comments

@firebird-automations
Copy link

Submitted by: Attila Molnár (e_pluribus_unum)

Hi Mark!

CREATE EXCEPTION EX 'D''oh!';

create or alter procedure ex_test
as
begin
exception ex 'This error message does not appear in client side with JayBird';
end

execute procedure ex_test

FBSQLException contaions 'D''oh!'; not the custom message.

Thank You!

Commits: 1c84828 513eeda FirebirdSQL/fbt-repository@e31e59e FirebirdSQL/fbt-repository@02acab4

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

I wasn't aware of this functionality in Firebird (see: http://www.firebirdsql.org/file/documentation/reference_manuals/reference_material/html/langrefupd25-psql-exception.html#langrefupd25-psql-exception-custom-msg ). I would have expected this to be handled server-side and to work automatically without any changes client-side, so I am a bit surprised. I will check what I need to do to fix this.

I will initially schedule this for 2.2.8 but if it proves to be too complex (which I don't expect) I might defer to 3.0.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 2.2.8 [ 10664 ]

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

I just tested this and the current Jaybird 2.2 HEAD (2.2.7 + changes not related to exception handling) actually works as expected (against a Firebird 3 server). Which Firebird version are you using?

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Committed tests to Jaybird 2.2 branch and trunk that show this works. I will run the testsuite against the latest 2.1 and 2.5 this weekend.

@firebird-automations
Copy link
Author

Commented by: Attila Molnár (e_pluribus_unum)

My bad. My test case contained a string concat and one of the string was null.
Works as expected.

Sorry for bothering..

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

No problem: it allowed me to increase the test coverage. I will close this ticket as "cannot reproduce".

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Closed [ 6 ]

resolution: Cannot Reproduce [ 5 ]

Fix Version: Jaybird 2.2.8 [ 10664 ] =>

Fix Version: Jaybird 3.0 [ 10440 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants