Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete statement state transitions [JDBC410] #451

Closed
firebird-automations opened this issue Oct 6, 2015 · 6 comments
Closed

Incomplete statement state transitions [JDBC410] #451

firebird-automations opened this issue Oct 6, 2015 · 6 comments
Assignees
@mrotteveel
Labels
affect-version: Jaybird 3.0.0 component: jni/jna layer component: wire protocol fix-version: Jaybird 3.0.0 priority: blocker resolution: fixed type: bug

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

The statement state transitions in both JNA and wire are incomplete. Non-fatal errors during execute can cause the statement handle to become unusable as it is in the wrong statement state (EXECUTING) to allow a new prepare or execute.

Commits: 1eeb035
@firebird-automations
Copy link
Author

Modified by: @mrotteveel

priority: Major [ 3 ] => Blocker [ 1 ]

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

description: The statement state transitions in both JNA and wire are incomplete. Non-fatal errors during execute can cause the statement handle to become unusable as it is in the wrong statement state (EXECUTING) to allow a new prepare. => The statement state transitions in both JNA and wire are incomplete. Non-fatal errors during execute can cause the statement handle to become unusable as it is in the wrong statement state (EXECUTING) to allow a new prepare or execute.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Fixed the problem with statement execute by reverting to the previous state if an SQLException occurred during execute. This may require some further tweaking (eg marking the statement as ERROR for some fatal firebird errorcodes).

I am keeping this ticket open for now, as I am not entirely certain I have covered all cases.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

As far as I have been able to reason and test it should be OK now.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
affect-version: Jaybird 3.0.0 component: jni/jna layer component: wire protocol fix-version: Jaybird 3.0.0 priority: blocker resolution: fixed type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations