Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create correct SPB version for service parameter and request buffers [JDBC422] #463

Closed
firebird-automations opened this issue Feb 28, 2016 · 5 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

The AbstractFbService implement currently always creates an SPB version 2 for the non-attach service parameter buffer and service request buffer. The code needs to be changed to create the SPB version supported by the Firebird version.

When changing this, also look at the streaming backup / restore implementation to support larger buffers.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 3.0 [ 10440 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 3.1 [ 10441 ]

Fix Version: Jaybird 3.0 [ 10440 ] =>

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 5 [ 10871 ]

Fix Version: Jaybird 4 [ 10441 ] =>

@mrotteveel
Copy link
Member

SPB version 3 only applies to the attach parameter buffer, and not to others usages. Still looking at if there are some buffer usages that could be bigger.

@mrotteveel
Copy link
Member

Buffer usage can't be bigger either. Removed various TODOs

mrotteveel added a commit that referenced this issue Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants