Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JDBC 4.2 get/setLargeMaxRows beyond Integer.MAX_VALUE [JDBC443] #484

Closed
firebird-automations opened this issue Jul 18, 2016 · 5 comments
Closed

Add support for JDBC 4.2 get/setLargeMaxRows beyond Integer.MAX_VALUE [JDBC443] #484

firebird-automations opened this issue Jul 18, 2016 · 5 comments
Assignees
@mrotteveel
Labels
component: jdbc driver priority: major resolution: wontfix type: improvement

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Is related to JDBC329

Jaybird 3.0 implements get/setLargeMaxRows up to Integer.MAX_VALUE, add support beyond that.
@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 3.1 [ 10441 ]

description: Jaybird 3.0 implements get/setLargeMaxRows upto Integer.MAX_VALUE, add support beyond that. => Jaybird 3.0 implements get/setLargeMaxRows up to Integer.MAX_VALUE, add support beyond that.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Link: This issue is related to JDBC329 [ JDBC329 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Decided not to implement this. Use of setLargeMaxRows higher than Integer.MAX_VALUE will continue to set it to unlimited. There are a lot of assumptions in the implementation (and in the JDBC API) that this will never exceed Integer.MAX_VALUE anyway.

I will revisit this decision if someone brings a clear usecase for this ever requiring a value larger than 2^31-1.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: In Progress [ 3 ] => Closed [ 6 ]

resolution: Won't Fix [ 2 ]

Fix Version: Jaybird 4 [ 10441 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
component: jdbc driver priority: major resolution: wontfix type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations