Issue Details (XML | Word | Printable)

Key: JDBC-511
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Mark Rotteveel
Reporter: Mark Rotteveel
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Jaybird JCA/JDBC Driver

Add explicit automatic module name to Jaybird

Created: 30/Sep/17 12:39 PM   Updated: 03/Jan/18 04:36 PM
Component/s: JDBC driver
Affects Version/s: Jaybird 2.2.11, Jaybird 2.2.12, Jaybird 2.2.13, Jaybird 3.0.0, Jaybird 3.0.1, Jaybird 3.0.2
Fix Version/s: Jaybird 3.0.3, Jaybird 2.2.14, Jaybird 4


 Description  « Hide
Jaybird is currently not modularized, but it would be a good idea to add an explicit automatic module name so applications using Jaybird do not need to rely on the automatic module name that is inferred from the jar filename, which is not stable depending on where you sourced Jaybird (eg jaybird or jaybird-full when download from GitHub or firebirdsql.org, and jaybird-jdkXX when from maven).

To set the name, add an entry Automatic-Module-Name to the manifest.

I have posted a question to the Firebird-Java mailinglist to get some input, see https://groups.yahoo.com/neo/groups/Firebird-Java/conversations/messages/11377

For this automatic module name, I see two candidates:

- org.firebirdsql.jaybird
- org.firebirdsql.jdbc.jaybird

The first is short and to the point and includes the current 'name', and could allow for logical names when breaking up Jaybird into multiple modules (eg org.firebirdsql.jdbc for the JDBC driver part, org.firebirdsql.management for the management classes, etc), while still providing a single module that exports all.

The second aligns with the maven coordinates (dropping the -jdkXX suffix), but might be a bit awkward for naming modules in the future.


 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Mark Rotteveel added a comment - 21/Oct/17 10:57 AM - edited
The automatic module name will become org.firebirdsql.jaybird