Add explicit automatic module name to Jaybird [JDBC511] #547
Labels
affect-version: Jaybird 2.2.11
affect-version: Jaybird 2.2.12
affect-version: Jaybird 2.2.13
affect-version: Jaybird 3.0.0
affect-version: Jaybird 3.0.1
affect-version: Jaybird 3.0.2
component: jdbc driver
fix-version: Jaybird 2.2.14
fix-version: Jaybird 3.0.3
fix-version: Jaybird 4
priority: major
resolution: fixed
type: improvement
Submitted by: @mrotteveel
Jaybird is currently not modularized, but it would be a good idea to add an explicit automatic module name so applications using Jaybird do not need to rely on the automatic module name that is inferred from the jar filename, which is not stable depending on where you sourced Jaybird (eg jaybird or jaybird-full when download from GitHub or http://firebirdsql.org, and jaybird-jdkXX when from maven).
To set the name, add an entry Automatic-Module-Name to the manifest.
I have posted a question to the Firebird-Java mailinglist to get some input, see https://groups.yahoo.com/neo/groups/Firebird-Java/conversations/messages/11377 (archive)
For this automatic module name, I see two candidates:
- org.firebirdsql.jaybird
- org.firebirdsql.jdbc.jaybird
The first is short and to the point and includes the current 'name', and could allow for logical names when breaking up Jaybird into multiple modules (eg org.firebirdsql.jdbc for the JDBC driver part, org.firebirdsql.management for the management classes, etc), while still providing a single module that exports all.
The second aligns with the maven coordinates (dropping the -jdkXX suffix), but might be a bit awkward for naming modules in the future.
Commits: 28e287a 7079566 e0b63a5 5e1bd8b f13cfbe
The text was updated successfully, but these errors were encountered: