Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebirdVersionMetaData for 3.0 does not contain all keywords [JDBC554] #587

Closed
firebird-automations opened this issue Oct 1, 2018 · 3 comments

Comments

@firebird-automations
Copy link

Submitted by: Arlo O'Keeffe (denosian)

If I look at the list of reserved words that are introduced in Firebird 3.0:

https://firebirdsql.org/file/documentation/release_notes/html/en/3_0/rnfb30-reswords.html

not all of them appear in

https://github.com/FirebirdSQL/jaybird/blob/master/src/main/org/firebirdsql/jdbc/FirebirdVersionMetaData.java#L35

For example UNKNOWN is missing. Is this on purpose?

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

This enum is to implement DatabaseMetaData.getSQLKeywords, which specifies "Retrieves a comma-separated list of all of this database's SQL keywords that are NOT also SQL:2003 keywords." (see https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getSQLKeywords--). This is also documented on https://github.com/FirebirdSQL/jaybird/blob/master/src/main/org/firebirdsql/jdbc/FirebirdVersionMetaData.java#L93

UNKNOWN is an SQL:2003 keyword, and is therefor not included in the list. The purpose of the method is to supply reserved words in addition to the SQL standard reserved words.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Closed [ 6 ]

resolution: Won't Fix [ 2 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

But thanks for reporting, I just noticed that the list contains a number of keywords that are also listed in SQL:2003. So I created JDBC555 to re-check the list in its entirety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants