Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-check FirebirdVersionMetaData and remove words reserved in SQL:2003 [JDBC555] #588

Closed
firebird-automations opened this issue Oct 1, 2018 · 7 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

When looking at JDBC554 I noticed some Firebird 3 keywords that are reserved in SQL:2003 (for example the REGR_* keywords, CHAR_LENGTH and CHARACTER_LENGTH). Check keyword list and fix.

It is probably best to rebuild (and retain) the full list of keywords, and re-check fully, instead of just removing the currently present keywords that are in SQL:2003.

Commits: 6b0d6fd

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.6 [ 10883 ]

Fix Version: Jaybird 4 [ 10441 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

description: When looking at JDBC554 I noticed some Firebird 3 keywords that are in SQL:2003 (for example the REGR_* keywords). Check keyword list and fix. => When looking at JDBC554 I noticed some Firebird 3 keywords that are reserved in SQL:2003 (for example the REGR_* keywords, CHAR_LENGTH and CHARACTER_LENGTH). Check keyword list and fix.

It is probably best to rebuild (and retain) the full list of keywords, and re-check fully, instead of just removing the currently present keywords that are in SQL:2003.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

I may have done this because - not sure - Hibernate 5 used an incomplete keyword list (or from an earlier SQL standard version), or maybe because JDBC 3 and earlier used SQL92 as baseline; including those additional keywords allows for better support of quoting object names when necessary. I'll need to double check that.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 3.0.6 [ 10883 ] =>

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Created a tool to track reserved/non-reserved words (at https://github.com/mrotteveel/firebird-reserved-words) and refreshed the lists in FirebirdVersionMetaData

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment