Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up DatabaseMetaData implementation [JDBC558] #591

Closed
firebird-automations opened this issue Oct 27, 2018 · 0 comments
Closed

Break up DatabaseMetaData implementation [JDBC558] #591

firebird-automations opened this issue Oct 27, 2018 · 0 comments
Assignees
@mrotteveel
Labels
component: jdbc driver fix-version: Jaybird 5 type: task

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

DatabaseMetaData is a large interface, resulting in a very large implementation class. It would be better to split off some parts (especially the result set producing classes) to their own implementation classes. This would allow for:

1. Smaller class (easier to understand)
2. Not loading things not used (but also simplify some reuse, eg RowDescriptor instances)
3. Allow for version-specific implementations
mrotteveel added a commit that referenced this issue Oct 17, 2022
@mrotteveel
#591 Move DatabaseMetaData.getProcedures implementation to separate c…
45a8919 
…lasses
mrotteveel added a commit that referenced this issue Oct 22, 2022
@mrotteveel
#591 Move DatabaseMetaData.getProcedureColumns implementation to sepa…
e99df4e 
…rate classes

+ Some related changes for consistency between solutions
mrotteveel added a commit that referenced this issue Oct 23, 2022
@mrotteveel
#591 Move DatabaseMetaData.getTables implementation to separate classes
5efff24
mrotteveel added a commit that referenced this issue Nov 5, 2022
@mrotteveel
#591 Move DatabaseMetaData.getColumns implementation to separate classes
967ad15
mrotteveel added a commit that referenced this issue Nov 5, 2022
@mrotteveel
#591 Move DatabaseMetaData.getColumnPrivileges implementation to sepa…
695e787 
…rate classes
mrotteveel added a commit that referenced this issue Nov 5, 2022
@mrotteveel
#591 Remove methods made obsolete by rewrite of getTables
1db8253
mrotteveel added a commit that referenced this issue Nov 10, 2022
@mrotteveel
#591 Move getTableTypes and getTableTypeNames implementation into Get…
d769f78 
…Tables
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getTablePrivileges implementation to separ…
a451977 
…ate class

+ Move some parts to OO specific implementation as temporary solution
+ Cleanup/common fixes for consistency
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getBestRowIdentifier implementation to sep…
16adb5b 
…arate class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getVersionColumns implementation to separa…
e991599 
…te class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getPrimaryKeys implementation to separate …
6c619b9 
…class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getImportedKeys implementation to separate…
210d5bb 
… class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getExportedKeys implementation to separate…
281d8e8 
… class

+ some refactoring for shared things
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getCrossReference implementation to separa…
f70787b 
…te class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getTypeInfo implementation to separate class
3d7a77e
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getIndexInfo implementation to separate class
9069b85
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getCatalogs implementation to separate class
c9cd3f8
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getUDTs implementation to separate class
9199553
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getAttributes implementation to separate c…
cf38f5b 
…lass
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getSuperTypes implementation to separate c…
0925988 
…lass
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getSuperTables implementation to separate …
960a52c 
…class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getClientInfoProperties implementation to …
9822454 
…separate class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getSchemas implementation to separate class
9583df6
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Move DatabaseMetaData.getPseudoColumns implementation to separat…
3b41a8b 
…e class
mrotteveel added a commit that referenced this issue Nov 26, 2022
@mrotteveel
#591 Refactor OODatabaseMetaData.getSchemas to GetSchemas implementation
631cbf3
mrotteveel added a commit that referenced this issue Dec 7, 2022
@mrotteveel
#591 Fix internal change note after decision to deprecate OOREMOTE
1a59b69 
The metadata refactoring will not be applied (further) to OODatabaseMetaData.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrotteveel mrotteveel

Labels
component: jdbc driver fix-version: Jaybird 5 type: task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrotteveel @firebird-automations