Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to trace statements execution [JDBC597] #628

Closed
firebird-automations opened this issue Oct 1, 2019 · 8 comments
Closed

Ability to trace statements execution [JDBC597] #628

firebird-automations opened this issue Oct 1, 2019 · 8 comments

Comments

@firebird-automations
Copy link

Submitted by: @vasiliy-yashkov

Attachments:
jdp-2019-06-ability-to-control-statements-execution.md

Each statement has a StatementState, which allows to get the status of it, but specified mechanism does not allow to centrally monitor any statements synchronously. To do this need to wrap all statements at the application level and do this implementation there. However, at the application level, it is impossible to trace fetch, since it is impossible to subscribe to it. It is proposed to add a mechanism for synchronous tracing of all statements and fetches.

Commits: 2d1c37b 84fd175

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

I would like to have a Jaybird Design Proposal for this, see https://github.com/FirebirdSQL/jaybird/blob/master/devdoc/jdp/jdp-2019-01-jaybird-design-proposal.md

Specifically, I want a more detailed explanation of this feature, how this is expected to be used, and the reasons for this addition for Jaybird. And if possible, considered alternatives and implications of this change (eg security, possible misuse/memory leaks, etc).

@firebird-automations
Copy link
Author

Commented by: @vasiliy-yashkov

This file provides a design proposal of the ability to control statements.

@firebird-automations
Copy link
Author

Modified by: @vasiliy-yashkov

Attachment: http://jdp-2019-06-ability-to-control-statements-execution.md [ 13389 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Thanks. As I also commented on the pull request, I'll provide feedback this weekend.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 4.0.0-beta-2 [ 10902 ]

Fix Version: Jaybird 4 [ 10441 ]

description: Each statement has a StatementState, which allows to get the status of it, but specified mechanism does not allow to centrally monitor any statements synchronously. To do this need to wrap all statements at the application level and do this implementation there. However, at the application level, it is impossible to control fetch, since it is impossible to subscribe to it. It is proposed to add a mechanism for synchronous control all statements and fetches. => Each statement has a StatementState, which allows to get the status of it, but specified mechanism does not allow to centrally monitor any statements synchronously. To do this need to wrap all statements at the application level and do this implementation there. However, at the application level, it is impossible to trace fetch, since it is impossible to subscribe to it. It is proposed to add a mechanism for synchronous tracing of all statements and fetches.

summary: Ability to control statements execution => Ability to trace statements execution

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

I have merged this with some changes, see 52a0fbb

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment