Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebird 4: INT128 support [JDBC624] #654

Closed
firebird-automations opened this issue Jun 24, 2020 · 9 comments
Closed

Firebird 4: INT128 support [JDBC624] #654

firebird-automations opened this issue Jun 24, 2020 · 9 comments

Comments

@firebird-automations
Copy link

Submitted by: @mrotteveel

Jira_subtask_inward JDBC466

The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type is a BigInteger (and not a BigDecimal).

Commits: 4347030 de64153 d6a09d5 df4f2d9

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 4.0.1 [ 10921 ]

Component: JDBC driver [ 10053 ]

description: The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

description: The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly. => The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type should be a BigInteger (and not a BigDecimal).

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

description: The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type should be a BigInteger (and not a BigDecimal).

=>

The Int128 type is now formally exposed as type INT128, and not just as part of NUMERIC/DECIMAL with precision >= 19. Add support in the metadata for reporting this correctly.

Also make sure the backing type is a BigInteger (and not a BigDecimal).

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

Fix Version: Jaybird 5 [ 10871 ]

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

On further consideration, it would probably be better to identify INT128 as Types.NUMERIC or Types.DECIMAL and let the default type be BigDecimal, that would allow it to be transparently used by other tools.

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Wrote jdp-2020-08 to define this feature: https://github.com/FirebirdSQL/jaybird/blob/master/devdoc/jdp/jdp-2020-08-int128-support.md

@firebird-automations
Copy link
Author

Commented by: @mrotteveel

Implemented

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @mrotteveel

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants