Issue Details (XML | Word | Printable)

Key: JDBC-631
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Mark Rotteveel
Reporter: Honza Hubeny
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Jaybird JDBC Driver

NullPointerException in private static class SetNetworkTimeoutCommand - class FBConnection file ./src/main/org/firebirdsql/jdbc/FBConnection.java when using HikariCP

Created: 11/Aug/20 09:34 AM   Updated: 11/Aug/20 02:38 PM
Component/s: JDBC driver
Affects Version/s: Jaybird 4
Fix Version/s: Jaybird 4.0.1, Jaybird 5

Environment: Linux Ubuntu 20.04 LTS. Bug found when using Hikari CP 2.4.13 together with latest stable Jaybird 4.0. Both libraries compiled for Java 7.


 Description  « Hide
I use Hikari CP together with Jaybird 3. I try to upgrade Jaybird lib to 4. However it is not possible now becouse of following error:

Pool init with max 2 idle connections and 30 seconds timeout
.....
HikariConfig config = new HikariConfig();
config.setAutoCommit(false);
config.setMinimumIdle(2);
config.setMaximumPoolSize(100);
config.setIdleTimeout(30000);
connectionPool = new HikariDataSource(config);
......


When the hikari pool has more than 2 idle connections for more than 30 second then the class

com.zaxxer.hikari.pool.PoolBase

calls method

void quietlyCloseConnection(final Connection connection, final String closureReason)
   {
      if (connection != null) {
         try {
            LOGGER.debug("{} - Closing connection {}: {}", poolName, connection, closureReason);
            try {
               setNetworkTimeout(connection, SECONDS.toMillis(15));
            }
            finally {
               connection.close(); // continue with the close even if setNetworkTimeout() throws
            }
         }
         catch (Throwable e) {
            LOGGER.debug("{} - Closing connection {} failed", poolName, connection, e);
         }
      }
   }
               
here is first called asynchronous setNetworkTimeout(connection, SECONDS.toMillis(15));
the final product of this call is call of method setNetworkTImeout in Jaybird class FBConnection. After that the connection is immediately closed.
However, the jaybird SetNetworkTimeoutCommand is executed in another thread and in the run() method of the private static SetNetworkTimeoutCommand is call to
connection.getFbDatabase().setNetworkTimeout(timeoutMillis);

Unfortunatelly the call connection.getFbDatabase() returns null pointer (connection is already closed by the hikari CP).




The content of FBConnection with the source of error follows

   @Override
    public void setNetworkTimeout(Executor executor, int milliseconds) throws SQLException {
        SecurityManager securityManager = System.getSecurityManager();
        if (securityManager != null) {
            SQLPermission sqlPermission = new SQLPermission(PERMISSION_SET_NETWORK_TIMEOUT);
            securityManager.checkPermission(sqlPermission);
        }
        if (executor == null) {
            throw FbExceptionBuilder
                    .forException(JaybirdErrorCodes.jb_invalidExecutor)
                    .toFlatSQLException();
        }
        if (milliseconds < 0) {
            throw FbExceptionBuilder
                    .forException(JaybirdErrorCodes.jb_invalidTimeout)
                    .toFlatSQLException();
        }
        checkValidity();

        executor.execute(new SetNetworkTimeoutCommand(this, milliseconds));
    }

    private static class SetNetworkTimeoutCommand implements Runnable {

        private final WeakReference<FBConnection> connectionReference;
        private final int timeoutMillis;

        SetNetworkTimeoutCommand(FBConnection connection, int timeoutMillis) {
            connectionReference = new WeakReference<>(connection);
            this.timeoutMillis = timeoutMillis;
        }

        @Override
        public void run() {
            FBConnection connection = connectionReference.get();
            if (connection != null) {
                try {
                    connection.getFbDatabase().setNetworkTimeout(timeoutMillis);
                } catch (SQLException e) {
                    log.error("Exception during asynchronous handling of setNetworkTimeout", e);
                }
            }
        }
    }






 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Mark Rotteveel made changes - 11/Aug/20 10:22 AM
Field Original Value New Value
Environment Linux Ubuntu 20.04 LTS. Bug finded when using Hikari CP 2.4.13 together with latest stable Jaybird 4.0. Both libraries compiled for Java 7. Linux Ubuntu 20.04 LTS. Bug found when using Hikari CP 2.4.13 together with latest stable Jaybird 4.0. Both libraries compiled for Java 7.
Mark Rotteveel made changes - 11/Aug/20 10:23 AM
Fix Version/s Jaybird 4.0.1 [ 10921 ]
Mark Rotteveel made changes - 11/Aug/20 10:23 AM
Fix Version/s Jaybird 5 [ 10871 ]
Mark Rotteveel made changes - 11/Aug/20 10:47 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Mark Rotteveel made changes - 11/Aug/20 02:38 PM
Status Resolved [ 5 ] Closed [ 6 ]