Commented by: Vaclav Slavik (vslavik)

Patch with the fix.

Commented by: Vladimir Tsvigun (praktik)

Hi!

> + USHORT option = 0;
> if (connection->autoCommit)
> connection->commitAuto();
> - // Close cursors too.
> + else
> + option = DSQL_close; // Close cursors too.

It's bad variant. If the execute connection->commitAuto(); and
typeStmt == stmtSelect && openCursor (it's use commitRetaining)
then the cursor will be never closed

Check up
if ( isActiveCursor() )
{
ISC_STATUS statusVector [20];
connection->GDS->_dsql_free_statement (statusVector, &statementHandle, DSQL_close);
if ( statusVector[1] )
THROW_ISC_EXCEPTION (connection, statusVector);
}

And please use FbODBC ver 2.0
And please inform result
Thanks
--
Best regards,
Vladimir Tsvigun

Commented by: Vaclav Slavik (vslavik)

Works for me, thanks!

Commented by: Pabloj (pabloj_sourceforge)

Did this go into the official code?

Commented by: @samofatov

Yes, it seems so.

cvs diff -u -r 1.18.2.15 -r 1.18.2.16 IscStatement.cpp

Index: IscStatement.cpp

RCS file: /cvsroot/firebird/OdbcJdbc/IscDbc/IscStatement.cpp,v
retrieving revision 1.18.2.15
retrieving revision 1.18.2.16
diff -u -u -r1.18.2.15 -r1.18.2.16
--- IscStatement.cpp 22 Mar 2007 17:44:27 -0000 1.18.2.15
+++ IscStatement.cpp 26 Aug 2007 17:21:05 -0000 1.18.2.16
@@ -559,8 +559,6 @@
resultSets.deleteItem (resultSet);
if (resultSets.isEmpty())
{
- openCursor = false;
- typeStmt = stmtNone;
if ( connection )
{
if ( transactionLocal )
@@ -570,13 +568,20 @@
}
else if ( connection->transactionInfo.autoCommit )
connection->commitAuto();
- // Close cursors too.
- ISC_STATUS statusVector[20];
- connection->GDS->_dsql_free_statement( statusVector, &statementHandle, DSQL_close );
- // Cursor already closed or not assigned
- if ( statusVector[1] && statusVector[1] != 335544569 )
- THROW_ISC_EXCEPTION (connection, statusVector);
+
+ if ( isActiveCursor() )
+ {
+ // Close cursors too.
+ ISC_STATUS statusVector[20];
+ connection->GDS->_dsql_free_statement( statusVector, &statementHandle, DSQL_close );
+ // Cursor already closed or not assigned
+ if ( statusVector[1] && statusVector[1] != 335544569)
+ THROW_ISC_EXCEPTION (connection, statusVector);
+ }
}
+
+ openCursor = false;
+ typeStmt = stmtNone;
}
}