Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.4 and FDB - backup throws an exception [PYFB42] #61

Closed
firebird-automations opened this issue Sep 8, 2014 · 4 comments
Closed

Comments

@firebird-automations
Copy link

Submitted by: Werner F Bruhin (werner)

Attachments:
fdbAndPy3.patch

When trying to do a backup and exception is thrown, details please see the thread "Python 3.4 and FDB - backup" on mailto:firebird-python@yahoogroups.com

Commits: a3d6310 FirebirdSQL/fbt-repository@7ed6220

@firebird-automations
Copy link
Author

Commented by: Werner F Bruhin (werner)

Suggested patch to correct the issue.

Change is basically to keep the 'source_database' as a string and only convert it to a byte stream in the method services.add_database_name.

There are some additional calls to ibase.b(database) which should probably also be changed, the ones I noted are in:

get_limbo_transaction_ids
_resolve_limbo_transaction
commit_limbo_transaction
rollback_limbo_transaction
get_statistics
nbackup
set_default_page_buffers
set_sweep_interval
set_reserve_page_space
activate_shadow
shutdown
bring_online
sweep
repair

@firebird-automations
Copy link
Author

Modified by: Werner F Bruhin (werner)

Attachment: fdbAndPy3.patch [ 12585 ]

@firebird-automations
Copy link
Author

Modified by: @pcisar

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 1.4.2 [ 10641 ]

@firebird-automations
Copy link
Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants