Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible stack corruption in DFW\check_dependencies [CORE1051] #1470

Closed
firebird-automations opened this issue Dec 11, 2006 · 9 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @hvlad

DFW\check_dependencies have a variable
SLONG dep_counts[obj_count];

but obj_count is not a number of object types.

Look at obj.h :
...
const int obj_count = 11;
const int obj_user_group = 12;
const int obj_sql_role = 13;
const int obj_generator = 14;
const int obj_udf = 15;
const int obj_blob_filter = 16;
const int obj_collation = 17;

Proposed solution is to create

obj_type_MAX = 18

and use it in DFW\check_dependencies instead of obj_count. Remove obj_count as it is not used anywhere

Also remove from RDB$TYPES record described not existed object type "DEPENDENT_COUNT"

Commits: 639278c 2e51ae8 a810712

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 1.5.4 [ 10100 ]

Fix Version: 2.0.1 [ 10090 ]

Fix Version: 2.1 [ 10041 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

assignee: Vlad Horsun [ hvlad ] =>

@firebird-automations
Copy link
Collaborator Author

Commented by: @pcisar

Reopened to update ticket information.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Closed [ 6 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Fix Version: 2.1 Alpha 1 [ 10150 ]

Fix Version: 2.1.0 [ 10041 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Reopened [ 4 ] => Closed [ 6 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 11388 ] => Firebird [ 15441 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment