New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect shutdown, when database is in phisical backup mode [CORE943] #1344
Comments
Modified by: @dyemanovassignee: Dmitry Yemanov [ dimitr ] |
Modified by: @dyemanovFix Version: 2.0.1 [ 10090 ] |
Commented by: @dyemanov Question: If the above sequence works as expected and doesn't allow new connections, would you consider okay that the following operation: |
Commented by: Yakov Hrebtov (jake) What is going to happen if database shuted down during real nbackup -B command? What if nbackup finishes (and should unlock database), but database is in shutdown mode? |
Commented by: Yakov Hrebtov (jake) Of course, waiting for online is bad thing too. |
Commented by: @dyemanov I'm wondering why you would need a shutdown in order to perform a physical backup? |
Commented by: Yakov Hrebtov (jake) It seems, you missunderstood me (or I'm missunderstanding you :). Consider the following sequence: As I understand your initial question, you asking about throwing error on step 3 in this sequence. |
Modified by: @dyemanovstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.1 [ 10041 ] |
Commented by: @pcisar Dmitry, can you please comment on how this issue was fixed (i.e. the new behaviour)? There is no clear resolution in current comments and I really don't want to decode it from code changes :) It's necessary to verify the fix and for inclusion into documentation. |
Commented by: @dyemanov It has been discussed in fb-devel. The new behavior is: |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Commented by: @pcisar Reopened to update ticket information. |
Modified by: @pcisarWorkflow: jira [ 11225 ] => Firebird [ 15297 ] |
Modified by: @pavel-zotovQA Status: No test |
Submitted by: Yakov Hrebtov (jake)
If database is in phisical backup mode, then it cannot be properly shutdowned.
No errors are reported and new connections allowed after shutdown.
Steps to reproduce:
1. Put database in phisical backup mode:
/opt/firebird/bin/nbackup -L mydb
(it can be a real backup command, not just DB lock)
2. Shutdown database:
/opt/firebird/bin/gfix -shut single -force 0 mydb
(No errors are reported here!)
3. Check that new connections are still allowed.
Commits: 05473ab dd0931d 85aa6f1 915e919 c906e4d a064dc6
The text was updated successfully, but these errors were encountered: